Restore Ellie links on the examples site#198
Merged
Merged
Conversation
2.0.3 fixes a decoder bug that dropped the per-example ellieLink, so the "Edit on Ellie" links disappeared from the examples site after the 2.0 upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Edit on Ellie" links disappeared from the examples site after the upgrade to elm-example-publisher 2.0 (#193). The build logs show Ellies are still being published successfully to the Ellie API, but the links never render in the generated HTML.
Root cause
A decoder bug in elm-example-publisher 2.0.2:
publishElliesattachesellieLinkat the example's top level (matching itsExampletype), butExamplePublisher.elm's decoder read it fromDecode.at ["tags", "ellieLink"].Decode.maybeswallowed the mismatch, soellieLinkwas alwaysNothingandellieLinkViewrendered nothing.Verified end-to-end:
/ColorSpaceInterpolations/): zeroelliereferences.Edit on Ellie→ellie-app.com/rLmdYVnpzsva1present.Nothing, fixed path →Just <url>.Fix
Fixed upstream in elm-example-publisher (decode the top-level
ellieLinkfield) and released as 2.0.3. This PR bumps the devDependency^2.0.2→^2.0.3.The elm-review CLI pin (2.10.2) in the lockfile is preserved.
Verification
Links will return once Netlify rebuilds from this branch. Worth a quick
curl .../ColorSpaceInterpolations/ | grep -i ellieon the deploy preview to confirm.